feat(agent): add config option to not instrument framework exception handlers #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1113 +/- ##
==========================================
- Coverage 78.11% 78.11% -0.01%
==========================================
Files 193 193
Lines 27991 27997 +6
==========================================
+ Hits 21866 21870 +4
- Misses 6125 6127 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lavarou
approved these changes
Sep 3, 2025
mfulb
approved these changes
Sep 3, 2025
This was referenced Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our instrumentation of framework exception handlers can result in excess, unwanted error events being generated. Sometimes, these events are plentiful and diverse enough that manual filtering through them with our other error related INI options is too much effort. In cases like that, this setting exists as an easy solution. Errors may still appear on spans, but error events will, in general, not be created. This works especially well when the customer inserts their own error handling logic into the stack, so that they are able to call our API for certain, specific errors that they wish to be error events.